diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2024-03-15 15:54:43 +0100 |
|---|---|---|
| committer | Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2024-04-30 18:57:08 +0200 |
| commit | 80bd81cb7a87e98c17f8faa31b0700c466c94e92 (patch) | |
| tree | 38c263cd0532449259c1cb8ee92c346499484156 /drivers/pwm | |
| parent | pwm: Make pwmchip_[sg]et_drvdata() a wrapper around dev_set_drvdata() (diff) | |
| download | linux-80bd81cb7a87e98c17f8faa31b0700c466c94e92.tar.gz linux-80bd81cb7a87e98c17f8faa31b0700c466c94e92.tar.bz2 linux-80bd81cb7a87e98c17f8faa31b0700c466c94e92.zip | |
pwm: stm32: Add error messages in .probe()'s error paths
Giving an indication about the problem if probing a device fails is a
nice move. Do that for the stm32 pwm driver.
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/20240315145443.982807-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/pwm-stm32.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 0c028d17c075..ffe572b76174 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -648,11 +648,13 @@ static int stm32_pwm_probe(struct platform_device *pdev) priv->max_arr = ddata->max_arr; if (!priv->regmap || !priv->clk) - return -EINVAL; + return dev_err_probe(dev, -EINVAL, "Failed to get %s\n", + priv->regmap ? "clk" : "regmap"); ret = stm32_pwm_probe_breakinputs(priv, np); if (ret) - return ret; + return dev_err_probe(dev, ret, + "Failed to configure breakinputs\n"); stm32_pwm_detect_complementary(priv); @@ -664,7 +666,8 @@ static int stm32_pwm_probe(struct platform_device *pdev) ret = devm_pwmchip_add(dev, chip); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, + "Failed to register pwmchip\n"); platform_set_drvdata(pdev, chip); |