diff options
author | 2008-04-29 01:02:20 -0700 | |
---|---|---|
committer | 2008-04-29 08:06:21 -0700 | |
commit | 8b594007c381b01464358bc4b89bfb85ec7f076a (patch) | |
tree | 0536adf6d4d4290106866a8f84568e691ab45697 /drivers/s390/char/tape_proc.c | |
parent | usb: use non-racy method for proc entries creation (diff) | |
download | linux-8b594007c381b01464358bc4b89bfb85ec7f076a.tar.gz linux-8b594007c381b01464358bc4b89bfb85ec7f076a.tar.bz2 linux-8b594007c381b01464358bc4b89bfb85ec7f076a.zip |
s390: use non-racy method for proc entries creation
Use proc_create() to make sure that ->proc_fops be setup before gluing PDE to
main tree.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/s390/char/tape_proc.c')
-rw-r--r-- | drivers/s390/char/tape_proc.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/s390/char/tape_proc.c b/drivers/s390/char/tape_proc.c index 0c39636b2174..e7c888c14e71 100644 --- a/drivers/s390/char/tape_proc.c +++ b/drivers/s390/char/tape_proc.c @@ -111,6 +111,7 @@ static int tape_proc_open(struct inode *inode, struct file *file) static const struct file_operations tape_proc_ops = { + .owner = THIS_MODULE, .open = tape_proc_open, .read = seq_read, .llseek = seq_lseek, @@ -124,14 +125,12 @@ void tape_proc_init(void) { tape_proc_devices = - create_proc_entry ("tapedevices", S_IFREG | S_IRUGO | S_IWUSR, - NULL); + proc_create("tapedevices", S_IFREG | S_IRUGO | S_IWUSR, NULL, + &tape_proc_ops); if (tape_proc_devices == NULL) { PRINT_WARN("tape: Cannot register procfs entry tapedevices\n"); return; } - tape_proc_devices->proc_fops = &tape_proc_ops; - tape_proc_devices->owner = THIS_MODULE; } /* |