diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2021-07-13 21:35:19 +0200 |
|---|---|---|
| committer |  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| 2021-07-21 11:53:41 +0200 |
| commit | a7bdb9a9767360c2b4096bbb379e73022b274483 (patch) | |
| tree | 167d1241fd3eaacb1837bfbd5aef60951a11d809 /drivers/s390/cio/eadm_sch.c | |
| parent | PCI: endpoint: Make struct pci_epf_driver::remove return void (diff) | |
| download | linux-a7bdb9a9767360c2b4096bbb379e73022b274483.tar.gz linux-a7bdb9a9767360c2b4096bbb379e73022b274483.tar.bz2 linux-a7bdb9a9767360c2b4096bbb379e73022b274483.zip | |
s390/cio: Make struct css_driver::remove return void
The driver core ignores the return value of css_remove()
(because there is only little it can do when a device disappears) and
all callbacks return 0 anyhow.
So make it impossible for future drivers to return an unused error code
by changing the remove prototype to return void.
The real motivation for this change is the quest to make struct
bus_type::remove return void, too.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210713193522.1770306-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/s390/cio/eadm_sch.c')
| -rw-r--r-- | drivers/s390/cio/eadm_sch.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/s390/cio/eadm_sch.c b/drivers/s390/cio/eadm_sch.c index c8964e0a23e7..15bdae5981ca 100644 --- a/drivers/s390/cio/eadm_sch.c +++ b/drivers/s390/cio/eadm_sch.c @@ -282,7 +282,7 @@ disable: spin_unlock_irq(sch->lock); } -static int eadm_subchannel_remove(struct subchannel *sch) +static void eadm_subchannel_remove(struct subchannel *sch) { struct eadm_private *private = get_eadm_private(sch); @@ -297,8 +297,6 @@ static int eadm_subchannel_remove(struct subchannel *sch) spin_unlock_irq(sch->lock); kfree(private); - - return 0; } static void eadm_subchannel_shutdown(struct subchannel *sch) |