diff options
author | 2014-11-13 14:27:41 +0100 | |
---|---|---|
committer | 2014-11-24 14:45:26 +0100 | |
commit | 1e6f2416044c062a56091ebf8d76760956dd5872 (patch) | |
tree | 53b83ab97cc475c37f957bb85167ae8cb2ccd550 /drivers/scsi/3w-sas.c | |
parent | scsi: avoid ->change_queue_depth indirection for queue full tracking (diff) | |
download | linux-1e6f2416044c062a56091ebf8d76760956dd5872.tar.gz linux-1e6f2416044c062a56091ebf8d76760956dd5872.tar.bz2 linux-1e6f2416044c062a56091ebf8d76760956dd5872.zip |
scsi: don't allow setting of queue_depth bigger than can_queue
We won't ever queue more commands than the host allows. Instead of
letting drivers either reject or ignore this case handle it in
common code. Note that various driver use internal constant or
variables that are assigned to both shost->can_queue and checked
in ->change_queue_depth - I did remove those checks as well.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Diffstat (limited to 'drivers/scsi/3w-sas.c')
-rw-r--r-- | drivers/scsi/3w-sas.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index ac0c2544a470..547756b7d5bf 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -198,8 +198,6 @@ static int twl_change_queue_depth(struct scsi_device *sdev, int queue_depth, if (reason != SCSI_QDEPTH_DEFAULT) return -EOPNOTSUPP; - if (queue_depth > TW_Q_LENGTH-2) - queue_depth = TW_Q_LENGTH-2; scsi_adjust_queue_depth(sdev, queue_depth); return queue_depth; } /* End twl_change_queue_depth() */ |