aboutsummaryrefslogtreecommitdiff
path: root/drivers/soc/mediatek
diff options
context:
space:
mode:
authorGravatar Roger Lu <roger.lu@mediatek.com> 2023-02-16 21:25:43 +0800
committerGravatar Matthias Brugger <matthias.bgg@gmail.com> 2023-03-30 11:29:42 +0200
commitedecdcccc1e971b1f0c077ef1f1f714251864aa1 (patch)
treef2aee466704b5bac09aa266fe3d91e70399bf7e6 /drivers/soc/mediatek
parentsoc: mediatek: mtk-svs: delete node name check (diff)
downloadlinux-edecdcccc1e971b1f0c077ef1f1f714251864aa1.tar.gz
linux-edecdcccc1e971b1f0c077ef1f1f714251864aa1.tar.bz2
linux-edecdcccc1e971b1f0c077ef1f1f714251864aa1.zip
soc: mediatek: mtk-svs: fix passing zero to 'PTR_ERR'
nvmem_cell_get() cannot return NULL so checking for NULL is wrong here. Signed-off-by: Roger Lu <roger.lu@mediatek.com> Fixes: 6c7174fd90a4690 ("soc: mediatek: mtk-svs: use svs get efuse common function") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/202302160720.N64SWT4l-lkp@intel.com/ Link: https://lore.kernel.org/r/20230216132543.814-1-roger.lu@mediatek.com Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Diffstat (limited to 'drivers/soc/mediatek')
-rw-r--r--drivers/soc/mediatek/mtk-svs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index a7eb019b5157..8127fb6d587b 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1726,7 +1726,7 @@ static int svs_get_efuse_data(struct svs_platform *svsp,
struct nvmem_cell *cell;
cell = nvmem_cell_get(svsp->dev, nvmem_cell_name);
- if (IS_ERR_OR_NULL(cell)) {
+ if (IS_ERR(cell)) {
dev_err(svsp->dev, "no \"%s\"? %ld\n",
nvmem_cell_name, PTR_ERR(cell));
return PTR_ERR(cell);