diff options
| author |  Richard Fitzgerald <rf@opensource.cirrus.com>
| 2022-09-17 15:02:56 +0100 |
|---|---|---|
| committer |  Vinod Koul <vkoul@kernel.org>
| 2022-09-20 10:35:39 +0530 |
| commit | 560458df5f144fb3547a9fde8e0b7b2143ef0711 (patch) | |
| tree | 9eb15d2191fe58008c1b4b44841482084c3e2129 /drivers/soundwire/bus.c | |
| parent | soundwire: qcom: do not send status of device 0 during alert (diff) | |
| download | linux-560458df5f144fb3547a9fde8e0b7b2143ef0711.tar.gz linux-560458df5f144fb3547a9fde8e0b7b2143ef0711.tar.bz2 linux-560458df5f144fb3547a9fde8e0b7b2143ef0711.zip | |
soundwire: bus: Fix wrong port number in sdw_handle_slave_alerts()
for_each_set_bit() gives the bit-number counting from 0 (LSbit==0).
When processing INTSTAT2, bit 0 is DP4 so the port number is (bit + 4).
Likewise for INTSTAT3 bit 0 is DP11 so port number is (bit + 11).
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220917140256.689678-1-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire/bus.c')
| -rw-r--r-- | drivers/soundwire/bus.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 8eded1a55227..df0ae869ee51 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1622,7 +1622,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) port = buf2[0] & SDW_SCP_INTSTAT2_PORT4_10; for_each_set_bit(bit, &port, 8) { /* scp2 ports start from 4 */ - port_num = bit + 3; + port_num = bit + 4; sdw_handle_port_interrupt(slave, port_num, &port_status[port_num]); @@ -1634,7 +1634,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) port = buf2[1] & SDW_SCP_INTSTAT3_PORT11_14; for_each_set_bit(bit, &port, 8) { /* scp3 ports start from 11 */ - port_num = bit + 10; + port_num = bit + 11; sdw_handle_port_interrupt(slave, port_num, &port_status[port_num]); |