diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-03-30 23:03:41 +0200 |
|---|---|---|
| committer |  Mark Brown <broonie@kernel.org>
| 2023-04-04 12:47:11 +0100 |
| commit | dea8e70f68f4105279bbc6de4d68d89fb07665c2 (patch) | |
| tree | 1f82fd2d6d1f333984ccab31ae9fa9232886a275 /drivers/spi/spi-qup.c | |
| parent | spi: qup: Don't skip cleanup in remove's error path (diff) | |
| download | linux-dea8e70f68f4105279bbc6de4d68d89fb07665c2.tar.gz linux-dea8e70f68f4105279bbc6de4d68d89fb07665c2.tar.bz2 linux-dea8e70f68f4105279bbc6de4d68d89fb07665c2.zip | |
spi: qup: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230330210341.2459548-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-qup.c')
| -rw-r--r-- | drivers/spi/spi-qup.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 9efa56e2ee9d..944ef6b42bce 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -1270,7 +1270,7 @@ disable_clk: } #endif /* CONFIG_PM_SLEEP */ -static int spi_qup_remove(struct platform_device *pdev) +static void spi_qup_remove(struct platform_device *pdev) { struct spi_master *master = dev_get_drvdata(&pdev->dev); struct spi_qup *controller = spi_master_get_devdata(master); @@ -1295,8 +1295,6 @@ static int spi_qup_remove(struct platform_device *pdev) pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static const struct of_device_id spi_qup_dt_match[] = { @@ -1321,7 +1319,7 @@ static struct platform_driver spi_qup_driver = { .of_match_table = spi_qup_dt_match, }, .probe = spi_qup_probe, - .remove = spi_qup_remove, + .remove_new = spi_qup_remove, }; module_platform_driver(spi_qup_driver); |