diff options
author | 2016-07-12 11:08:42 +0000 | |
---|---|---|
committer | 2016-07-14 17:21:52 +0100 | |
commit | 9f135787b1d29b0069059b580c1c77965e5e8af4 (patch) | |
tree | 3e57432e79a3d0a544490ed7ed5fbfed1ef0c160 /drivers/spi/spi-s3c64xx.c | |
parent | spi: s3c64xx: do not disable the clock while configuring the spi (diff) | |
download | linux-9f135787b1d29b0069059b580c1c77965e5e8af4.tar.gz linux-9f135787b1d29b0069059b580c1c77965e5e8af4.tar.bz2 linux-9f135787b1d29b0069059b580c1c77965e5e8af4.zip |
spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove()
Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-s3c64xx.c')
-rw-r--r-- | drivers/spi/spi-s3c64xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index df88fa161d8a..001c9ebf884d 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1211,7 +1211,7 @@ err0: static int s3c64xx_spi_remove(struct platform_device *pdev) { - struct spi_master *master = spi_master_get(platform_get_drvdata(pdev)); + struct spi_master *master = platform_get_drvdata(pdev); struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master); pm_runtime_get_sync(&pdev->dev); |