diff options
| author |  Wolfram Sang <wsa+renesas@sang-engineering.com>
| 2024-04-30 13:41:37 +0200 |
|---|---|---|
| committer |  Mark Brown <broonie@kernel.org>
| 2024-04-30 23:57:30 +0900 |
| commit | e66480aed4a194f278da1e46ec45221b3983216f (patch) | |
| tree | ea085d18d9197c58846ccc24d68fb7319ef23120 /drivers/spi | |
| parent | spi: pic32-sqi: use 'time_left' variable with wait_for_completion_timeout() (diff) | |
| download | linux-e66480aed4a194f278da1e46ec45221b3983216f.tar.gz linux-e66480aed4a194f278da1e46ec45221b3983216f.tar.bz2 linux-e66480aed4a194f278da1e46ec45221b3983216f.zip | |
spi: pic32: use 'time_left' variable with wait_for_completion_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:
timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;
with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240430114142.28551-6-wsa+renesas@sang-engineering.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-pic32.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index 709edb70ad7d..b8bcc220e96d 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -498,7 +498,7 @@ static int pic32_spi_one_transfer(struct spi_controller *host, { struct pic32_spi *pic32s; bool dma_issued = false; - unsigned long timeout; + unsigned long time_left; int ret; pic32s = spi_controller_get_devdata(host); @@ -545,8 +545,8 @@ static int pic32_spi_one_transfer(struct spi_controller *host, } /* wait for completion */ - timeout = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ); - if (timeout == 0) { + time_left = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ); + if (time_left == 0) { dev_err(&spi->dev, "wait error/timedout\n"); if (dma_issued) { dmaengine_terminate_all(host->dma_rx); |