aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/greybus/connection.c
diff options
context:
space:
mode:
authorGravatar Johan Hovold <johan@hovoldconsulting.com> 2015-10-13 19:10:21 +0200
committerGravatar Greg Kroah-Hartman <gregkh@google.com> 2015-10-14 12:00:09 -0700
commitaae5a44ff5a22c3c3398e68c89a4513c75725fd7 (patch)
tree2ed421b801b7388a2dd9541070bf08d7010d77f7 /drivers/staging/greybus/connection.c
parentgreybus: es1/es2: clean up error messages (diff)
downloadlinux-aae5a44ff5a22c3c3398e68c89a4513c75725fd7.tar.gz
linux-aae5a44ff5a22c3c3398e68c89a4513c75725fd7.tar.bz2
linux-aae5a44ff5a22c3c3398e68c89a4513c75725fd7.zip
greybus: connection: replace pr_err with dev_err
Replace a couple of pr_err with more informative dev_err and clean up the messages somewhat. Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/connection.c')
-rw-r--r--drivers/staging/greybus/connection.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index bd3f83b2ccb6..1158674f2201 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -178,7 +178,7 @@ gb_connection_create_range(struct greybus_host_device *hd,
* about holding the connection lock.
*/
if (bundle && gb_connection_intf_find(bundle->intf, cport_id)) {
- pr_err("duplicate interface cport id 0x%04hx\n", cport_id);
+ dev_err(parent, "cport 0x%04hx already connected\n", cport_id);
return NULL;
}
@@ -223,8 +223,8 @@ gb_connection_create_range(struct greybus_host_device *hd,
connection->hd_cport_id = CPORT_ID_BAD;
put_device(&connection->dev);
- pr_err("failed to add connection device for cport 0x%04hx\n",
- cport_id);
+ dev_err(parent, "failed to register connection to cport %04hx: %d\n",
+ cport_id, retval);
goto err_remove_ida;
}