aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/hikey9xx
diff options
context:
space:
mode:
authorGravatar Alex Dewar <alex.dewar90@gmail.com> 2020-09-21 22:21:47 +0100
committerGravatar Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2020-09-22 09:51:28 +0200
commitc823f6a7980b3b0972faf2abf50e120269a26f93 (patch)
tree23cb9c90cbb0115e3d81a0bcfb21f1449b49dcf5 /drivers/staging/hikey9xx
parentstaging: rtl8192u: clean up comparsions to NULL (diff)
downloadlinux-c823f6a7980b3b0972faf2abf50e120269a26f93.tar.gz
linux-c823f6a7980b3b0972faf2abf50e120269a26f93.tar.bz2
linux-c823f6a7980b3b0972faf2abf50e120269a26f93.zip
staging: hikey9xx: Fix incorrect assignment
In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its default value is assigned to priv->eye_diagram_param, rather than to priv->tx_vboost_lvl. Fix this. Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670") Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR) Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> Link: https://lore.kernel.org/r/20200921212146.34662-1-alex.dewar90@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/hikey9xx')
-rw-r--r--drivers/staging/hikey9xx/phy-hi3670-usb3.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
index 42dbc20a0b9a..4fc013911a78 100644
--- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
+++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
@@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev)
if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl",
&priv->tx_vboost_lvl))
- priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST;
+ priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST;
phy = devm_phy_create(dev, NULL, &hi3670_phy_ops);
if (IS_ERR(phy))