aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/iio
diff options
context:
space:
mode:
authorGravatar David Lechner <dlechner@baylibre.com> 2023-09-21 09:43:45 -0500
committerGravatar Jonathan Cameron <Jonathan.Cameron@huawei.com> 2023-09-24 18:54:59 +0100
commit5e99f692d4e32e3250ab18d511894ca797407aec (patch)
treef4a899825ebd2267e2aa664c9082c4116fa55c92 /drivers/staging/iio
parentstaging: iio: resolver: ad2s1210: fix ad2s1210_show_fault (diff)
downloadlinux-5e99f692d4e32e3250ab18d511894ca797407aec.tar.gz
linux-5e99f692d4e32e3250ab18d511894ca797407aec.tar.bz2
linux-5e99f692d4e32e3250ab18d511894ca797407aec.zip
staging: iio: resolver: ad2s1210: fix not restoring sample gpio in channel read
In theory, this code path should not be reachable because of the previous switch statement. But just in case we should make sure we are restoring the SAMPLE gpio to its original state before returning in addition to releasing the mutex lock. Signed-off-by: David Lechner <dlechner@baylibre.com> Link: https://lore.kernel.org/r/20230921144400.62380-5-dlechner@baylibre.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/staging/iio')
-rw-r--r--drivers/staging/iio/resolver/ad2s1210.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index 7fb2d9e3196f..f695ca0547e4 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -510,8 +510,8 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev,
ret = IIO_VAL_INT;
break;
default:
- mutex_unlock(&st->lock);
- return -EINVAL;
+ ret = -EINVAL;
+ break;
}
error_ret: