aboutsummaryrefslogtreecommitdiff
path: root/drivers/thermal/imx8mm_thermal.c
diff options
context:
space:
mode:
authorGravatar Marcus Folkesson <marcus.folkesson@gmail.com> 2022-10-14 09:35:07 +0200
committerGravatar Daniel Lezcano <daniel.lezcano@kernel.org> 2022-12-14 15:25:39 +0100
commitd37edc7370273306d8747097fafa62436c1cfe16 (patch)
treeb830f93c1d32de2d0a4557f0689e16a40d886625 /drivers/thermal/imx8mm_thermal.c
parentthermal/drivers/imx8mm_thermal: Use GENMASK() when appropriate (diff)
downloadlinux-d37edc7370273306d8747097fafa62436c1cfe16.tar.gz
linux-d37edc7370273306d8747097fafa62436c1cfe16.tar.bz2
linux-d37edc7370273306d8747097fafa62436c1cfe16.zip
thermal/drivers/imx8mm_thermal: Validate temperature range
Check against the upper temperature limit (125 degrees C) before consider the temperature valid. Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit") Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Reviewed-by: Jacky Bai <ping.bai@nxp.com> Link: https://lore.kernel.org/r/20221014073507.1594844-1-marcus.folkesson@gmail.com Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Diffstat (limited to 'drivers/thermal/imx8mm_thermal.c')
-rw-r--r--drivers/thermal/imx8mm_thermal.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index 68608d8e5e29..182cc207afe9 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)
u32 val;
val = readl_relaxed(tmu->base + TRITSR) & TRITSR_TEMP0_VAL_MASK;
+
+ /*
+ * Do not validate against the V bit (bit 31) due to errata
+ * ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
+ */
+
*temp = val * 1000;
- if (*temp < VER1_TEMP_LOW_LIMIT)
+ if (*temp < VER1_TEMP_LOW_LIMIT || *temp > VER2_TEMP_HIGH_LIMIT)
return -EAGAIN;
return 0;