diff options
| author |  Yang Li <yang.lee@linux.alibaba.com>
| 2023-01-06 08:59:51 +0800 |
|---|---|---|
| committer |  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| 2023-01-10 20:33:26 +0100 |
| commit | e7fcfe67f9f410736b758969477b17ea285e8e6c (patch) | |
| tree | 7a6704f62e9f2b88d39518d685f04cf91624f104 /drivers/thermal | |
| parent | thermal/x86_pkg_temp_thermal: Add support for handling dynamic tjmax (diff) | |
| download | linux-e7fcfe67f9f410736b758969477b17ea285e8e6c.tar.gz linux-e7fcfe67f9f410736b758969477b17ea285e8e6c.tar.bz2 linux-e7fcfe67f9f410736b758969477b17ea285e8e6c.zip | |
thermal: intel: Fix unsigned comparison with less than zero
The return value from the call to intel_tcc_get_tjmax() is int, which can
be a negative error code. However, the return value is being assigned to
an u32 variable 'tj_max', so making 'tj_max' an int.
Eliminate the following warning:
./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING: Unsigned expression compared with zero: tj_max < 0
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/thermal')
| -rw-r--r-- | drivers/thermal/intel/intel_soc_dts_iosf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel/intel_soc_dts_iosf.c index 2138693d8afd..8c26f7b2316b 100644 --- a/drivers/thermal/intel/intel_soc_dts_iosf.c +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors *intel_soc_dts_iosf_init( { struct intel_soc_dts_sensors *sensors; bool notification; - u32 tj_max; + int tj_max; int ret; int i; |