diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2021-01-14 18:57:17 +0100 |
|---|---|---|
| committer |  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| 2021-01-15 10:21:42 +0100 |
| commit | 6da629c85871a0cb65fad3e0c0a440d64002b0a7 (patch) | |
| tree | 5bee26005bb430fffc3ce846d548a686ad991800 /drivers/tty/vcc.c | |
| parent | tty: hvcs: Drop unnecessary if block (diff) | |
| download | linux-6da629c85871a0cb65fad3e0c0a440d64002b0a7.tar.gz linux-6da629c85871a0cb65fad3e0c0a440d64002b0a7.tar.bz2 linux-6da629c85871a0cb65fad3e0c0a440d64002b0a7.zip | |
tty: vcc: Drop unnecessary if block
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.
So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210114175718.137483-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/vcc.c')
| -rw-r--r-- | drivers/tty/vcc.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 9ffd42e333b8..d9b0dc6deae9 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev) { struct vcc_port *port = dev_get_drvdata(&vdev->dev); - if (!port) - return -ENODEV; - del_timer_sync(&port->rx_timer); del_timer_sync(&port->tx_timer); |