diff options
| author |  Badhri Jagan Sridharan <badhri@google.com>
| 2020-12-02 19:19:08 -0800 |
|---|---|---|
| committer |  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| 2020-12-09 14:45:53 +0100 |
| commit | 3bac42f02d41dd85da7afb9ffc3f4539fad20cc5 (patch) | |
| tree | 16f2650eb438ed81063df7933fb9d2395c71efa7 /drivers/usb | |
| parent | usb: typec: tcpm: Pass down negotiated rev to update retry count (diff) | |
| download | linux-3bac42f02d41dd85da7afb9ffc3f4539fad20cc5.tar.gz linux-3bac42f02d41dd85da7afb9ffc3f4539fad20cc5.tar.bz2 linux-3bac42f02d41dd85da7afb9ffc3f4539fad20cc5.zip | |
usb: typec: tcpm: Clear send_discover in tcpm_check_send_discover
tcpm_check_send_discover does not clear the send_discover flag
when any of the following conditions are not met.
1. data_role is TYPEC_HOST
2. link is pd_capable
Discovery indentity would anyways not be attempted during
the current session anymore when the above conditions are not
met. Hence clear the send_discover flag here to prevent
tcpm_enable_frs_work from rescheduling indefinetly.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
Link: https://lore.kernel.org/r/20201203031908.1491542-1-badhri@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/typec/tcpm/tcpm.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index c73bc3a8356a..1c64b831bbb5 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -3035,10 +3035,9 @@ static inline enum tcpm_state unattached_state(struct tcpm_port *port) static void tcpm_check_send_discover(struct tcpm_port *port) { if (port->data_role == TYPEC_HOST && port->send_discover && - port->pd_capable) { + port->pd_capable) tcpm_send_vdm(port, USB_SID_PD, CMD_DISCOVER_IDENT, NULL, 0); - port->send_discover = false; - } + port->send_discover = false; } static void tcpm_swap_complete(struct tcpm_port *port, int result) |