diff options
| author |  Uwe Kleine-König <uwe@kleine-koenig.org>
| 2023-03-10 23:41:28 +0100 |
|---|---|---|
| committer |  Li Yang <leoyang.li@nxp.com>
| 2023-05-30 18:58:43 -0500 |
| commit | 59272ad8d9e8ea6398a96f8c6d62da284bf2ae6e (patch) | |
| tree | ceaacaf7f7099dd194d0e5782d222606ce44d8f4 /drivers/vfio/fsl-mc | |
| parent | soc: fsl: dpio: Suppress duplicated error reporting on device remove (diff) | |
| download | linux-59272ad8d9e8ea6398a96f8c6d62da284bf2ae6e.tar.gz linux-59272ad8d9e8ea6398a96f8c6d62da284bf2ae6e.tar.bz2 linux-59272ad8d9e8ea6398a96f8c6d62da284bf2ae6e.zip | |
bus: fsl-mc: Make remove function return void
The value returned by an fsl-mc driver's remove function is mostly
ignored. (Only an error message is printed if the value is non-zero
and then device removal continues unconditionally.)
So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Diffstat (limited to 'drivers/vfio/fsl-mc')
| -rw-r--r-- | drivers/vfio/fsl-mc/vfio_fsl_mc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c index c89a047a4cd8..f2140e94d41e 100644 --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c @@ -570,7 +570,7 @@ static void vfio_fsl_mc_release_dev(struct vfio_device *core_vdev) mutex_destroy(&vdev->igate); } -static int vfio_fsl_mc_remove(struct fsl_mc_device *mc_dev) +static void vfio_fsl_mc_remove(struct fsl_mc_device *mc_dev) { struct device *dev = &mc_dev->dev; struct vfio_fsl_mc_device *vdev = dev_get_drvdata(dev); @@ -578,7 +578,6 @@ static int vfio_fsl_mc_remove(struct fsl_mc_device *mc_dev) vfio_unregister_group_dev(&vdev->vdev); dprc_remove_devices(mc_dev, NULL, 0); vfio_put_device(&vdev->vdev); - return 0; } static const struct vfio_device_ops vfio_fsl_mc_ops = { |