diff options
| author |  Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
| 2017-01-19 18:58:24 +0200 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2017-01-20 12:35:09 -0500 |
| commit | 176b0cbffdf3f240a19386635811034dfe0fc8ab (patch) | |
| tree | 605b65d522132c033adee2b07fa3f18b2520f1e1 /drivers | |
| parent | net: ethernet: ti: cpsw: remove dual check from common res usage function (diff) | |
| download | linux-176b0cbffdf3f240a19386635811034dfe0fc8ab.tar.gz linux-176b0cbffdf3f240a19386635811034dfe0fc8ab.tar.bz2 linux-176b0cbffdf3f240a19386635811034dfe0fc8ab.zip | |
net: ethernet: ti: cpsw: don't disable interrupts in ndo_open
No need to disable interrupts if no open devices,
they are disabled anyway.
Even no need to disable interrupts if some ndev is opened, In this
case shared resources are not touched, only parameters of ndev shell,
so no reason to disable them also. Removed lines have proved it.
So, no need in redundant check and interrupt disable.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/ti/cpsw.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 296ddf247e92..f79890546d96 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1480,8 +1480,6 @@ static int cpsw_ndo_open(struct net_device *ndev) return ret; } - if (!cpsw_common_res_usage_state(cpsw)) - cpsw_intr_disable(cpsw); netif_carrier_off(ndev); /* Notify the stack of the actual queue counts. */ |