diff options
author | 2014-09-15 13:00:19 -0400 | |
---|---|---|
committer | 2014-09-15 17:24:20 -0400 | |
commit | 5075314e4e4b559cc37675ad8a721a89bccd6284 (patch) | |
tree | 37d72bc57dd16717b15acbb14e5c98e7d36ced19 /drivers | |
parent | Merge branch 'bonding-cleanups' (diff) | |
download | linux-5075314e4e4b559cc37675ad8a721a89bccd6284.tar.gz linux-5075314e4e4b559cc37675ad8a721a89bccd6284.tar.bz2 linux-5075314e4e4b559cc37675ad8a721a89bccd6284.zip |
dsa: Split ops up, and avoid assigning tag_protocol and receive separately
This change addresses several issues.
First, it was possible to set tag_protocol without setting the ops pointer.
To correct that I have reordered things so that rcv is now populated before
we set tag_protocol.
Second, it didn't make much sense to keep setting the device ops each time a
new slave was registered. So by moving the receive portion out into root
switch initialization that issue should be addressed.
Third, I wanted to avoid sending tags if the rcv pointer was not registered
so I changed the tag check to verify if the rcv function pointer is set on
the root tree. If it is then we start sending DSA tagged frames.
Finally I split the device ops pointer in the structures into two spots. I
placed the rcv function pointer in the root switch since this makes it
easiest to access from there, and I placed the xmit function pointer in the
slave for the same reason.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions