aboutsummaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorGravatar Yunsheng Lin <linyunsheng@huawei.com> 2024-04-28 19:16:38 +0800
committerGravatar Jakub Kicinski <kuba@kernel.org> 2024-04-30 18:30:43 -0700
commit9f8eeea1643c213c0e1ad2e546a15536200d216b (patch)
tree01122840aeefafa388129b6b082332beaa5d91a5 /drivers
parentMerge branch 'vxlan-stats' (diff)
downloadlinux-9f8eeea1643c213c0e1ad2e546a15536200d216b.tar.gz
linux-9f8eeea1643c213c0e1ad2e546a15536200d216b.tar.bz2
linux-9f8eeea1643c213c0e1ad2e546a15536200d216b.zip
rxrpc: Fix using alignmask being zero for __page_frag_alloc_align()
rxrpc_alloc_data_txbuf() may be called with data_align being zero in none_alloc_txbuf() and rxkad_alloc_txbuf(), data_align is supposed to be an order-based alignment value, but zero is not a valid order-based alignment value, and '~(data_align - 1)' doesn't result in a valid mask-based alignment value for __page_frag_alloc_align(). Fix it by passing a valid order-based alignment value in none_alloc_txbuf() and rxkad_alloc_txbuf(). Also use page_frag_alloc_align() expecting an order-based alignment value in rxrpc_alloc_data_txbuf() to avoid doing the alignment converting operation and to catch possible invalid alignment value in the future. Remove the 'if (data_align)' checking too, as it is always true for a valid order-based alignment value. Fixes: 6b2536462fd4 ("rxrpc: Fix use of changed alignment param to page_frag_alloc_align()") Fixes: 49489bb03a50 ("rxrpc: Do zerocopy using MSG_SPLICE_PAGES and page frags") CC: Alexander Duyck <alexander.duyck@gmail.com> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com> Acked-by: David Howells <dhowells@redhat.com> Link: https://lore.kernel.org/r/20240428111640.27306-1-linyunsheng@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions