diff options
| author |  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
| 2022-02-21 22:59:35 +0000 |
|---|---|---|
| committer |  Marc Kleine-Budde <mkl@pengutronix.de>
| 2022-02-25 17:46:54 +0100 |
| commit | c5048a7b2c23ab589f3476a783bd586b663eda5b (patch) | |
| tree | 1acba004c729e50d0d4e1c196b6d0107388bac57 /drivers | |
| parent | can: gs_usb: change active_channels's type from atomic_t to u8 (diff) | |
| download | linux-c5048a7b2c23ab589f3476a783bd586b663eda5b.tar.gz linux-c5048a7b2c23ab589f3476a783bd586b663eda5b.tar.bz2 linux-c5048a7b2c23ab589f3476a783bd586b663eda5b.zip | |
can: rcar_canfd: rcar_canfd_channel_probe(): register the CAN device when fully ready
Register the CAN device only when all the necessary initialization is
completed. This patch makes sure all the data structures and locks are
initialized before registering the CAN device.
Link: https://lore.kernel.org/all/20220221225935.12300-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Pavel Machek <pavel@denx.de>
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/can/rcar/rcar_canfd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c index b7dc1c32875f..acd74725831f 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -1715,15 +1715,15 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch, netif_napi_add(ndev, &priv->napi, rcar_canfd_rx_poll, RCANFD_NAPI_WEIGHT); + spin_lock_init(&priv->tx_lock); + devm_can_led_init(ndev); + gpriv->ch[priv->channel] = priv; err = register_candev(ndev); if (err) { dev_err(&pdev->dev, "register_candev() failed, error %d\n", err); goto fail_candev; } - spin_lock_init(&priv->tx_lock); - devm_can_led_init(ndev); - gpriv->ch[priv->channel] = priv; dev_info(&pdev->dev, "device registered (channel %u)\n", priv->channel); return 0; |