diff options
| author |  Kent Overstreet <kent.overstreet@gmail.com>
| 2022-02-27 09:56:33 -0500 |
|---|---|---|
| committer |  Kent Overstreet <kent.overstreet@linux.dev>
| 2023-10-22 17:09:26 -0400 |
| commit | bf3efff5e4fc2dcd6e6c15578d3f08c301a13229 (patch) | |
| tree | cca40f2591a81ba52e14350a663266b83c78e43f /fs/bcachefs/btree_types.h | |
| parent | bcachefs: Kill bch2_btree_node_write_cond() (diff) | |
| download | linux-bf3efff5e4fc2dcd6e6c15578d3f08c301a13229.tar.gz linux-bf3efff5e4fc2dcd6e6c15578d3f08c301a13229.tar.bz2 linux-bf3efff5e4fc2dcd6e6c15578d3f08c301a13229.zip | |
bcachefs: Fix race leading to btree node write getting stuck
Checking btree_node_may_write() isn't atomic with the other btree flags,
dirty and need_write in particular. There was a rare race where we'd
unblock a node from writing while __btree_node_flush() was setting
need_write, and no thread would notice that the node was now both able
to write and needed to be written.
Fix this by adding btree node flags for will_make_reachable and
write_blocked that can be checked in the cmpxchg loop in
__bch2_btree_node_write.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/btree_types.h')
| -rw-r--r-- | fs/bcachefs/btree_types.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/bcachefs/btree_types.h b/fs/bcachefs/btree_types.h index 165466db222d..561406b4b7c2 100644 --- a/fs/bcachefs/btree_types.h +++ b/fs/bcachefs/btree_types.h @@ -434,6 +434,8 @@ struct btree_trans { x(read_error) \ x(dirty) \ x(need_write) \ + x(write_blocked) \ + x(will_make_reachable) \ x(noevict) \ x(write_idx) \ x(accessed) \ |