diff options
| author |  Kent Overstreet <kent.overstreet@gmail.com>
| 2022-02-21 05:05:29 -0500 |
|---|---|---|
| committer |  Kent Overstreet <kent.overstreet@linux.dev>
| 2023-10-22 17:09:24 -0400 |
| commit | 3117db99f30b26ebf09ecc323cbefcd51d83467b (patch) | |
| tree | 11a698224b70620242e2b7a18fde7701e8159374 /fs/bcachefs/journal_reclaim.c | |
| parent | bcachefs: opts.read_journal_only (diff) | |
| download | linux-3117db99f30b26ebf09ecc323cbefcd51d83467b.tar.gz linux-3117db99f30b26ebf09ecc323cbefcd51d83467b.tar.bz2 linux-3117db99f30b26ebf09ecc323cbefcd51d83467b.zip | |
bcachefs: Don't issue discards when in nochanges mode
When the nochanges option is selected, we're supposed to never issue
writes. Unfortunately, it seems discards were missed when implemnting
this, leading to some painful filesystem corruption.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/journal_reclaim.c')
| -rw-r--r-- | fs/bcachefs/journal_reclaim.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/bcachefs/journal_reclaim.c b/fs/bcachefs/journal_reclaim.c index d72b17dc935a..84cc952a7ac5 100644 --- a/fs/bcachefs/journal_reclaim.c +++ b/fs/bcachefs/journal_reclaim.c @@ -286,7 +286,8 @@ void bch2_journal_do_discards(struct journal *j) struct journal_device *ja = &ca->journal; while (should_discard_bucket(j, ja)) { - if (ca->mi.discard && + if (!c->opts.nochanges && + ca->mi.discard && bdev_max_discard_sectors(ca->disk_sb.bdev)) blkdev_issue_discard(ca->disk_sb.bdev, bucket_to_sector(ca, |