diff options
| author |  Kent Overstreet <kent.overstreet@gmail.com>
| 2022-06-18 19:55:32 -0400 |
|---|---|---|
| committer |  Kent Overstreet <kent.overstreet@linux.dev>
| 2023-10-22 17:09:34 -0400 |
| commit | a3d7afa5c1b62140168982747fd15c1999d991f4 (patch) | |
| tree | d1bd1ea4f390c17225ff423a5ef99450f8e177a3 /fs/bcachefs/subvolume.c | |
| parent | bcachefs: Improve checksum error messages (diff) | |
| download | linux-a3d7afa5c1b62140168982747fd15c1999d991f4.tar.gz linux-a3d7afa5c1b62140168982747fd15c1999d991f4.tar.bz2 linux-a3d7afa5c1b62140168982747fd15c1999d991f4.zip | |
bcachefs: Always use percpu_ref_tryget_live() on c->writes
If we're trying to get a ref and the refcount has been killed, it means
we're doing an emergency shutdown - we always want tryget_live().
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/subvolume.c')
| -rw-r--r-- | fs/bcachefs/subvolume.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/bcachefs/subvolume.c b/fs/bcachefs/subvolume.c index 8f41a06c3e11..60b60de83f3e 100644 --- a/fs/bcachefs/subvolume.c +++ b/fs/bcachefs/subvolume.c @@ -729,7 +729,7 @@ err: static void bch2_delete_dead_snapshots(struct bch_fs *c) { - if (unlikely(!percpu_ref_tryget(&c->writes))) + if (unlikely(!percpu_ref_tryget_live(&c->writes))) return; if (!queue_work(system_long_wq, &c->snapshot_delete_work)) @@ -931,7 +931,7 @@ int bch2_subvolume_wait_for_pagecache_and_delete_hook(struct btree_trans *trans, if (ret) return ret; - if (unlikely(!percpu_ref_tryget(&c->writes))) + if (unlikely(!percpu_ref_tryget_live(&c->writes))) return -EROFS; if (!queue_work(system_long_wq, &c->snapshot_wait_for_pagecache_and_delete_work)) |