diff options
| author |  Filipe Manana <fdmanana@suse.com>
| 2023-10-04 11:38:52 +0100 |
|---|---|---|
| committer |  David Sterba <dsterba@suse.com>
| 2023-10-12 16:44:18 +0200 |
| commit | 5ca1949b79f3b02215f1c075bf178fceeadda352 (patch) | |
| tree | 305dd58a33c044e7a6e583dd8f7e3bcf8e3a2c03 /fs/btrfs/btrfs_inode.h | |
| parent | btrfs: add and use helpers for reading and writing last_trans_committed (diff) | |
| download | linux-5ca1949b79f3b02215f1c075bf178fceeadda352.tar.gz linux-5ca1949b79f3b02215f1c075bf178fceeadda352.tar.bz2 linux-5ca1949b79f3b02215f1c075bf178fceeadda352.zip | |
btrfs: remove pointless barrier from btrfs_sync_file()
The memory barrier (smp_mb()) at btrfs_sync_file() is completely redundant
now that fs_info->last_trans_committed is read using READ_ONCE(), with the
helper btrfs_get_last_trans_committed(), and written using WRITE_ONCE()
with the helper btrfs_set_last_trans_committed().
This barrier was introduced in 2011, by commit a4abeea41adf ("Btrfs: kill
trans_mutex"), but even back then it was not correct since the writer side
(in btrfs_commit_transaction()), did not issue a pairing memory barrier
after it updated fs_info->last_trans_committed.
So remove this barrier.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/btrfs_inode.h')
0 files changed, 0 insertions, 0 deletions