diff options
| author |  Stefan Behrens <sbehrens@giantdisaster.de>
| 2013-09-05 16:58:43 +0200 |
|---|---|---|
| committer |  Chris Mason <chris.mason@fusionio.com>
| 2013-11-11 21:49:26 -0500 |
| commit | 69e9c6c6dc87587d8846e447febedefe037c14f8 (patch) | |
| tree | 557fc35afdf3bbee9ce0f46a2ce16ce1c386133c /fs/btrfs/inode-map.c | |
| parent | Linux 3.12 (diff) | |
| download | linux-69e9c6c6dc87587d8846e447febedefe037c14f8.tar.gz linux-69e9c6c6dc87587d8846e447febedefe037c14f8.tar.bz2 linux-69e9c6c6dc87587d8846e447febedefe037c14f8.zip | |
Btrfs: eliminate the exceptional root_tree refs=0
The fact that btrfs_root_refs() returned 0 for the tree_root caused
bugs in the past, therefore it is set to 1 with this patch and
(hopefully) all affected code is adapted to this change.
I verified this change by temporarily adding WARN_ON() checks
everywhere where btrfs_root_refs() is used, checking whether the
logic of the code is changed by btrfs_root_refs() returning 1
instead of 0 for root->root_key.objectid == BTRFS_ROOT_TREE_OBJECTID.
With these added checks, I ran the xfstests './check -g auto'.
The two roots chunk_root and log_root_tree that are only referenced
by the superblock and the log_roots below the log_root_tree still
have btrfs_root_refs() == 0, only the tree_root is changed.
Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
Diffstat (limited to 'fs/btrfs/inode-map.c')
| -rw-r--r-- | fs/btrfs/inode-map.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c index 2c66ddbbe670..d11e1c6610b6 100644 --- a/fs/btrfs/inode-map.c +++ b/fs/btrfs/inode-map.c @@ -412,8 +412,7 @@ int btrfs_save_ino_cache(struct btrfs_root *root, return 0; /* Don't save inode cache if we are deleting this root */ - if (btrfs_root_refs(&root->root_item) == 0 && - root != root->fs_info->tree_root) + if (btrfs_root_refs(&root->root_item) == 0) return 0; if (!btrfs_test_opt(root, INODE_MAP_CACHE)) |