diff options
| author |  Filipe Manana <fdmanana@suse.com>
| 2021-12-15 12:19:59 +0000 |
|---|---|---|
| committer |  David Sterba <dsterba@suse.com>
| 2022-03-14 13:13:46 +0100 |
| commit | 528ee697126fddaff448897c2d649bd756153c79 (patch) | |
| tree | 7adee460315dcfc1ff778cdcfc82d862d20d1e2e /fs/btrfs/inode.c | |
| parent | btrfs: don't log unnecessary boundary keys when logging directory (diff) | |
| download | linux-528ee697126fddaff448897c2d649bd756153c79.tar.gz linux-528ee697126fddaff448897c2d649bd756153c79.tar.bz2 linux-528ee697126fddaff448897c2d649bd756153c79.zip | |
btrfs: put initial index value of a directory in a constant
At btrfs_set_inode_index_count() we refer twice to the number 2 as the
initial index value for a directory (when it's empty), with a proper
comment explaining the reason for that value. In the next patch I'll
have to use that magic value in the directory logging code, so put
the value in a #define at btrfs_inode.h, to avoid hardcoding the
magic value again at tree-log.c.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/inode.c')
| -rw-r--r-- | fs/btrfs/inode.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 5bbea5ec31fc..5c7aeb588313 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5971,14 +5971,8 @@ static int btrfs_set_inode_index_count(struct btrfs_inode *inode) goto out; ret = 0; - /* - * MAGIC NUMBER EXPLANATION: - * since we search a directory based on f_pos we have to start at 2 - * since '.' and '..' have f_pos of 0 and 1 respectively, so everybody - * else has to start at 2 - */ if (path->slots[0] == 0) { - inode->index_cnt = 2; + inode->index_cnt = BTRFS_DIR_START_INDEX; goto out; } @@ -5989,7 +5983,7 @@ static int btrfs_set_inode_index_count(struct btrfs_inode *inode) if (found_key.objectid != btrfs_ino(inode) || found_key.type != BTRFS_DIR_INDEX_KEY) { - inode->index_cnt = 2; + inode->index_cnt = BTRFS_DIR_START_INDEX; goto out; } |