aboutsummaryrefslogtreecommitdiff
path: root/fs/debugfs
diff options
context:
space:
mode:
authorGravatar Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-02-18 11:08:17 +0100
committerGravatar Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-02-18 16:23:46 +0100
commitbc6de804d36b3709d54fa22bd128cbac91c11526 (patch)
tree9d54565ac0a7ba39ec1668939ce94bd1e9c54bab /fs/debugfs
parentdriver core: auxiliary bus: Fix calling stage for auxiliary bus init (diff)
downloadlinux-bc6de804d36b3709d54fa22bd128cbac91c11526.tar.gz
linux-bc6de804d36b3709d54fa22bd128cbac91c11526.tar.bz2
linux-bc6de804d36b3709d54fa22bd128cbac91c11526.zip
debugfs: be more robust at handling improper input in debugfs_lookup()
debugfs_lookup() doesn't like it if it is passed an illegal name pointer, or if the filesystem isn't even initialized yet. If either of these happen, it will crash the system, so fix it up by properly testing for valid input and that we are up and running before trying to find a file in the filesystem. Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: stable <stable@vger.kernel.org> Reported-by: Michael Walle <michael@walle.cc> Tested-by: Michael Walle <michael@walle.cc> Tested-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20210218100818.3622317-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/debugfs')
-rw-r--r--fs/debugfs/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 2fcf66473436..bbeb563cbe78 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char *name, struct dentry *parent)
{
struct dentry *dentry;
- if (IS_ERR(parent))
+ if (!debugfs_initialized() || IS_ERR_OR_NULL(name) || IS_ERR(parent))
return NULL;
if (!parent)