diff options
| author |  Kemeng Shi <shikemeng@huaweicloud.com>
| 2023-08-01 22:32:03 +0800 |
|---|---|---|
| committer |  Theodore Ts'o <tytso@mit.edu>
| 2023-08-03 10:47:30 -0400 |
| commit | bcb123ac9b9887478da4185b55dfbf1a72550848 (patch) | |
| tree | a6ff004d9206878bb0d206a33e1968e635719439 /fs/ext4/mballoc.c | |
| parent | ext4: return found group directly in ext4_mb_choose_next_group_goal_fast (diff) | |
| download | linux-bcb123ac9b9887478da4185b55dfbf1a72550848.tar.gz linux-bcb123ac9b9887478da4185b55dfbf1a72550848.tar.bz2 linux-bcb123ac9b9887478da4185b55dfbf1a72550848.zip | |
ext4: return found group directly in ext4_mb_choose_next_group_best_avail
Return good group when it's found in loop to remove futher check if good
group is found after loop.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20230801143204.2284343-10-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/mballoc.c')
| -rw-r--r-- | fs/ext4/mballoc.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 3b1f90dfb119..f9189f7566fb 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -1042,18 +1042,16 @@ static void ext4_mb_choose_next_group_best_avail(struct ext4_allocation_context ac->ac_g_ex.fe_len); grp = ext4_mb_find_good_group_avg_frag_lists(ac, frag_order); - if (grp) - break; + if (grp) { + *group = grp->bb_group; + ac->ac_flags |= EXT4_MB_CR_BEST_AVAIL_LEN_OPTIMIZED; + return; + } } - if (grp) { - *group = grp->bb_group; - ac->ac_flags |= EXT4_MB_CR_BEST_AVAIL_LEN_OPTIMIZED; - } else { - /* Reset goal length to original goal length before falling into CR_GOAL_LEN_SLOW */ - ac->ac_g_ex.fe_len = ac->ac_orig_goal_len; - *new_cr = CR_GOAL_LEN_SLOW; - } + /* Reset goal length to original goal length before falling into CR_GOAL_LEN_SLOW */ + ac->ac_g_ex.fe_len = ac->ac_orig_goal_len; + *new_cr = CR_GOAL_LEN_SLOW; } static inline int should_optimize_scan(struct ext4_allocation_context *ac) |