diff options
| author |  Jan Kara <jack@suse.cz>
| 2021-08-12 14:47:37 +0200 |
|---|---|---|
| committer |  Theodore Ts'o <tytso@mit.edu>
| 2021-08-30 23:36:50 -0400 |
| commit | b2bbb92f7042e8075fb036bf97043339576330c3 (patch) | |
| tree | 4c20fb5ecbd4ba370100ca42cf202850b1ed5644 /fs/ext4 | |
| parent | ext4: if zeroout fails fall back to splitting the extent node (diff) | |
| download | linux-b2bbb92f7042e8075fb036bf97043339576330c3.tar.gz linux-b2bbb92f7042e8075fb036bf97043339576330c3.tar.bz2 linux-b2bbb92f7042e8075fb036bf97043339576330c3.zip | |
ext4: fix e2fsprogs checksum failure for mounted filesystem
Commit 81414b4dd48 ("ext4: remove redundant sb checksum
recomputation") removed checksum recalculation after updating
superblock free space / inode counters in ext4_fill_super() based on
the fact that we will recalculate the checksum on superblock
writeout.
That is correct assumption but until the writeout happens (which can
take a long time) the checksum is incorrect in the buffer cache and if
programs such as tune2fs or resize2fs is called shortly after a file
system is mounted can fail. So return back the checksum recalculation
and add a comment explaining why.
Fixes: 81414b4dd48f ("ext4: remove redundant sb checksum recomputation")
Cc: stable@kernel.org
Reported-by: Boyang Xue <bxue@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Link: https://lore.kernel.org/r/20210812124737.21981-1-jack@suse.cz
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/super.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index dfa09a277b56..970013c93d3e 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5032,6 +5032,14 @@ no_journal: err = percpu_counter_init(&sbi->s_freeinodes_counter, freei, GFP_KERNEL); } + /* + * Update the checksum after updating free space/inode + * counters. Otherwise the superblock can have an incorrect + * checksum in the buffer cache until it is written out and + * e2fsprogs programs trying to open a file system immediately + * after it is mounted can fail. + */ + ext4_superblock_csum_set(sb); if (!err) err = percpu_counter_init(&sbi->s_dirs_counter, ext4_count_dirs(sb), GFP_KERNEL); |