diff options
| author |  Chao Yu <chao@kernel.org>
| 2023-04-10 10:12:22 +0800 |
|---|---|---|
| committer |  Jaegeuk Kim <jaegeuk@kernel.org>
| 2023-04-10 11:03:02 -0700 |
| commit | c9b3649a934d131151111354bcbb638076f03a30 (patch) | |
| tree | 63f5c5fc46b2cd9c764ceeb66b43ef2776c3825a /fs/f2fs/iostat.c | |
| parent | f2fs: fix to avoid use-after-free for cached IPU bio (diff) | |
| download | linux-c9b3649a934d131151111354bcbb638076f03a30.tar.gz linux-c9b3649a934d131151111354bcbb638076f03a30.tar.bz2 linux-c9b3649a934d131151111354bcbb638076f03a30.zip | |
f2fs: fix to drop all dirty pages during umount() if cp_error is set
xfstest generic/361 reports a bug as below:
f2fs_bug_on(sbi, sbi->fsync_node_num);
kernel BUG at fs/f2fs/super.c:1627!
RIP: 0010:f2fs_put_super+0x3a8/0x3b0
Call Trace:
generic_shutdown_super+0x8c/0x1b0
kill_block_super+0x2b/0x60
kill_f2fs_super+0x87/0x110
deactivate_locked_super+0x39/0x80
deactivate_super+0x46/0x50
cleanup_mnt+0x109/0x170
__cleanup_mnt+0x16/0x20
task_work_run+0x65/0xa0
exit_to_user_mode_prepare+0x175/0x190
syscall_exit_to_user_mode+0x25/0x50
do_syscall_64+0x4c/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
During umount(), if cp_error is set, f2fs_wait_on_all_pages() should
not stop waiting all F2FS_WB_CP_DATA pages to be writebacked, otherwise,
fsync_node_num can be non-zero after f2fs_wait_on_all_pages() causing
this bug.
In this case, to avoid deadloop in f2fs_wait_on_all_pages(), it needs
to drop all dirty pages rather than redirtying them.
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/iostat.c')
0 files changed, 0 insertions, 0 deletions