diff options
| author |  Jaegeuk Kim <jaegeuk@kernel.org>
| 2023-04-03 09:37:24 -0700 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org>
| 2023-04-04 13:57:30 -0700 |
| commit | da6ea0b050fa720302b56fbb59307e7c7531a342 (patch) | |
| tree | 811cfcf2a644a7d294f094603eb4449b3b0b7b0d /fs/f2fs | |
| parent | f2fs: fix iostat lock protection (diff) | |
| download | linux-da6ea0b050fa720302b56fbb59307e7c7531a342.tar.gz linux-da6ea0b050fa720302b56fbb59307e7c7531a342.tar.bz2 linux-da6ea0b050fa720302b56fbb59307e7c7531a342.zip | |
f2fs: fix null pointer panic in tracepoint in __replace_atomic_write_block
We got a kernel panic if old_addr is NULL.
https://bugzilla.kernel.org/show_bug.cgi?id=217266
BUG: kernel NULL pointer dereference, address: 0000000000000000
Call Trace:
<TASK>
f2fs_commit_atomic_write+0x619/0x990 [f2fs a1b985b80f5babd6f3ea778384908880812bfa43]
__f2fs_ioctl+0xd8e/0x4080 [f2fs a1b985b80f5babd6f3ea778384908880812bfa43]
? vfs_write+0x2ae/0x3f0
? vfs_write+0x2ae/0x3f0
__x64_sys_ioctl+0x91/0xd0
do_syscall_64+0x5c/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc
RIP: 0033:0x7f69095fe53f
Fixes: 2f3a9ae990a7 ("f2fs: introduce trace_f2fs_replace_atomic_write_block")
Cc: <stable@vger.kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs')
| -rw-r--r-- | fs/f2fs/segment.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index f88828987924..45128694eefa 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -257,7 +257,7 @@ retry: f2fs_put_dnode(&dn); trace_f2fs_replace_atomic_write_block(inode, F2FS_I(inode)->cow_inode, - index, *old_addr, new_addr, recover); + index, old_addr ? *old_addr : 0, new_addr, recover); return 0; } |