diff options
| author |  Trond Myklebust <trond.myklebust@hammerspace.com>
| 2022-05-14 10:08:14 -0400 |
|---|---|---|
| committer |  Anna Schumaker <Anna.Schumaker@Netapp.com>
| 2022-05-17 12:53:33 -0400 |
| commit | 6949493884fe88500de4af182588e071cf1544ee (patch) | |
| tree | 0750c8d19e973383c004e39f912ed72e146967e7 /fs/nfs | |
| parent | pNFS/files: Fall back to I/O through the MDS on non-fatal layout errors (diff) | |
| download | linux-6949493884fe88500de4af182588e071cf1544ee.tar.gz linux-6949493884fe88500de4af182588e071cf1544ee.tar.bz2 linux-6949493884fe88500de4af182588e071cf1544ee.zip | |
NFSv4: Don't hold the layoutget locks across multiple RPC calls
When doing layoutget as part of the open() compound, we have to be
careful to release the layout locks before we can call any further RPC
calls, such as setattr(). The reason is that those calls could trigger
a recall, which could deadlock.
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/nfs4proc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index a79f66432bd3..bf3ba541b9fb 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3098,6 +3098,10 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, } out: + if (opendata->lgp) { + nfs4_lgopen_release(opendata->lgp); + opendata->lgp = NULL; + } if (!opendata->cancelled) nfs4_sequence_free_slot(&opendata->o_res.seq_res); return ret; |