diff options
| author |  Alexey Dobriyan <adobriyan@gmail.com>
| 2014-08-08 14:21:25 -0700 |
|---|---|---|
| committer |  Linus Torvalds <torvalds@linux-foundation.org>
| 2014-08-08 15:57:22 -0700 |
| commit | dbcdb504417ae108a20454ef89776a614b948571 (patch) | |
| tree | 397a024e382d28f09ccb020d4a2daedd2d251e9d /fs/proc/base.c | |
| parent | proc: constify seq_operations (diff) | |
| download | linux-dbcdb504417ae108a20454ef89776a614b948571.tar.gz linux-dbcdb504417ae108a20454ef89776a614b948571.tar.bz2 linux-dbcdb504417ae108a20454ef89776a614b948571.zip | |
proc: add and remove /proc entry create checks
* remove proc_create(NULL, ...) check, let it oops
* warn about proc_create("", ...) and proc_create("very very long name", ...)
proc code keeps length as u8, no 256+ name length possible
* warn about proc_create("123", ...)
/proc/$PID and /proc/misc namespaces are separate things,
but dumb module might create funky a-la $PID entry.
* remove post mortem strchr('/') check
Triggering it implies either strchr() is buggy or memory corruption.
It should be VFS check anyway.
In reality, none of these checks will ever trigger,
it is preparation for the next patch.
Based on patch from Al Viro.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/proc/base.c')
| -rw-r--r-- | fs/proc/base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c index 79df9ff71afd..11375216b493 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2785,7 +2785,7 @@ struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, unsign unsigned tgid; struct pid_namespace *ns; - tgid = name_to_int(dentry); + tgid = name_to_int(&dentry->d_name); if (tgid == ~0U) goto out; @@ -3033,7 +3033,7 @@ static struct dentry *proc_task_lookup(struct inode *dir, struct dentry * dentry if (!leader) goto out_no_task; - tid = name_to_int(dentry); + tid = name_to_int(&dentry->d_name); if (tid == ~0U) goto out; |