aboutsummaryrefslogtreecommitdiff
path: root/fs/splice.c
diff options
context:
space:
mode:
authorGravatar Christoph Hellwig <hch@lst.de> 2023-06-14 16:03:38 +0200
committerGravatar Jens Axboe <axboe@kernel.dk> 2023-06-16 10:08:08 -0600
commit0b24be4691c9e6ea13ca70050d42a9f9032fa788 (patch)
tree7fcc84992a1ea76fd31d1ee290a139c266692a5c /fs/splice.c
parentMerge tag 'nvme-6.5-2023-06-16' of git://git.infradead.org/nvme into for-6.5/... (diff)
downloadlinux-0b24be4691c9e6ea13ca70050d42a9f9032fa788.tar.gz
linux-0b24be4691c9e6ea13ca70050d42a9f9032fa788.tar.bz2
linux-0b24be4691c9e6ea13ca70050d42a9f9032fa788.zip
splice: don't call file_accessed in copy_splice_read
copy_splice_read calls into ->read_iter to read the data, which already calls file_accessed. Fixes: 33b3b041543e ("splice: Add a func to do a splice from an O_DIRECT file without ITER_PIPE") Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Christian Brauner <brauner@kernel.org> Reviewed-by: David Howells <dhowells@redhat.com> Link: https://lore.kernel.org/r/20230614140341.521331-2-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/splice.c')
-rw-r--r--fs/splice.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/splice.c b/fs/splice.c
index 2420ead610a7..87c69fdb333d 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -368,7 +368,6 @@ ssize_t copy_splice_read(struct file *in, loff_t *ppos,
if (ret > 0) {
keep = DIV_ROUND_UP(ret, PAGE_SIZE);
*ppos = kiocb.ki_pos;
- file_accessed(in);
} else if (ret < 0) {
/*
* callers of ->splice_read() expect -EAGAIN on