diff options
| author |  Nathan Chancellor <nathan@kernel.org>
| 2023-10-18 11:10:31 -0700 |
|---|---|---|
| committer |  Steven Rostedt (Google) <rostedt@goodmis.org>
| 2023-10-18 14:20:17 -0400 |
| commit | b8a555dc31e5aa18d976de0bc228006e398a2e7d (patch) | |
| tree | 50e78fcd905d5fcbef95f6b8000d31d72c761b8d /fs/tracefs/event_inode.c | |
| parent | tracing: Make system_callback() function static (diff) | |
| download | linux-b8a555dc31e5aa18d976de0bc228006e398a2e7d.tar.gz linux-b8a555dc31e5aa18d976de0bc228006e398a2e7d.tar.bz2 linux-b8a555dc31e5aa18d976de0bc228006e398a2e7d.zip | |
eventfs: Use ERR_CAST() in eventfs_create_events_dir()
When building with clang and CONFIG_RANDSTRUCT_FULL=y, there is an error
due to a cast in eventfs_create_events_dir():
fs/tracefs/event_inode.c:734:10: error: casting from randomized structure pointer type 'struct dentry *' to 'struct eventfs_inode *'
734 | return (struct eventfs_inode *)dentry;
| ^
1 error generated.
Use the ERR_CAST() function to resolve the error, as it was designed for
this exact situation (casting an error pointer to another type).
Link: https://lore.kernel.org/linux-trace-kernel/20231018-ftrace-fix-clang-randstruct-v1-1-338cb214abfb@kernel.org
Closes: https://github.com/ClangBuiltLinux/linux/issues/1947
Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Diffstat (limited to 'fs/tracefs/event_inode.c')
| -rw-r--r-- | fs/tracefs/event_inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 1ccd100bc565..9f19b6608954 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -731,7 +731,7 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry return NULL; if (IS_ERR(dentry)) - return (struct eventfs_inode *)dentry; + return ERR_CAST(dentry); ei = kzalloc(sizeof(*ei), GFP_KERNEL); if (!ei) |