diff options
| author |  Dave Chinner <dchinner@redhat.com>
| 2022-04-21 10:34:33 +1000 |
|---|---|---|
| committer |  Dave Chinner <david@fromorbit.com>
| 2022-04-21 10:34:33 +1000 |
| commit | c7610dceed39d978ef1ee0f2ab5a3c8d2d54d120 (patch) | |
| tree | f849e0cae5f9e72330b61b8f1a190c5f226bc4da /fs/xfs/libxfs/xfs_log_format.h | |
| parent | xfs: embed the xlog_op_header in the commit record (diff) | |
| download | linux-c7610dceed39d978ef1ee0f2ab5a3c8d2d54d120.tar.gz linux-c7610dceed39d978ef1ee0f2ab5a3c8d2d54d120.tar.bz2 linux-c7610dceed39d978ef1ee0f2ab5a3c8d2d54d120.zip | |
xfs: log tickets don't need log client id
We currently set the log ticket client ID when we reserve a
transaction. This client ID is only ever written to the log by
a CIL checkpoint or unmount records, and so anything using a high
level transaction allocated through xfs_trans_alloc() does not need
a log ticket client ID to be set.
For the CIL checkpoint, the client ID written to the journal is
always XFS_TRANSACTION, and for the unmount record it is always
XFS_LOG, and nothing else writes to the log. All of these operations
tell xlog_write() exactly what they need to write to the log (the
optype) and build their own opheaders for start, commit and unmount
records. Hence we no longer need to set the client id in either the
log ticket or the xfs_trans.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/libxfs/xfs_log_format.h')
| -rw-r--r-- | fs/xfs/libxfs/xfs_log_format.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h index b322db523d65..2b89141ae81a 100644 --- a/fs/xfs/libxfs/xfs_log_format.h +++ b/fs/xfs/libxfs/xfs_log_format.h @@ -69,7 +69,6 @@ static inline uint xlog_get_cycle(char *ptr) /* Log Clients */ #define XFS_TRANSACTION 0x69 -#define XFS_VOLUME 0x2 #define XFS_LOG 0xaa #define XLOG_UNMOUNT_TYPE 0x556e /* Un for Unmount */ |