aboutsummaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_extfree_item.c
diff options
context:
space:
mode:
authorGravatar Darrick J. Wong <darrick.wong@oracle.com> 2017-04-20 15:09:05 -0700
committerGravatar Darrick J. Wong <darrick.wong@oracle.com> 2017-04-25 09:40:42 -0700
commitc4cf1acdb186436b88cc9aeaf08322bc49fec183 (patch)
tree182b16a4ff2cb81bf720e4d7d2666fa4851cee60 /fs/xfs/xfs_extfree_item.c
parentxfs: fix up quotacheck buffer list error handling (diff)
downloadlinux-c4cf1acdb186436b88cc9aeaf08322bc49fec183.tar.gz
linux-c4cf1acdb186436b88cc9aeaf08322bc49fec183.tar.bz2
linux-c4cf1acdb186436b88cc9aeaf08322bc49fec183.zip
xfs: better log intent item refcount checking
Use ASSERTs on the log intent item refcounts so that we fail noisily if anyone tries to double-free the item. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_extfree_item.c')
-rw-r--r--fs/xfs/xfs_extfree_item.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
index d7bc14906af8..44f8c5451210 100644
--- a/fs/xfs/xfs_extfree_item.c
+++ b/fs/xfs/xfs_extfree_item.c
@@ -290,6 +290,7 @@ void
xfs_efi_release(
struct xfs_efi_log_item *efip)
{
+ ASSERT(atomic_read(&efip->efi_refcount) > 0);
if (atomic_dec_and_test(&efip->efi_refcount)) {
xfs_trans_ail_remove(&efip->efi_item, SHUTDOWN_LOG_IO_ERROR);
xfs_efi_item_free(efip);