diff options
| author |  Kees Cook <keescook@chromium.org>
| 2020-06-03 13:28:45 -0700 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org>
| 2020-07-16 12:32:26 -0700 |
| commit | fea1120c56e2d5db1cfea67d455edea3f4f97947 (patch) | |
| tree | e38e912036167ddca003347353221935eb1da9c3 /fs/xfs | |
| parent | f2fs: Eliminate usage of uninitialized_var() macro (diff) | |
| download | linux-fea1120c56e2d5db1cfea67d455edea3f4f97947.tar.gz linux-fea1120c56e2d5db1cfea67d455edea3f4f97947.tar.bz2 linux-fea1120c56e2d5db1cfea67d455edea3f4f97947.zip | |
mm/debug_vm_pgtable: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings (e.g.
"unused variable"). If the compiler thinks it is uninitialized, either
simply initialize the variable or make compiler changes. As a precursor
to removing[2] this[3] macro[4], just initialize this variable to NULL.
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Fixes: 399145f9eb6c ("mm/debug: add tests validating architecture page table helpers")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'fs/xfs')
0 files changed, 0 insertions, 0 deletions