aboutsummaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorGravatar Kent Overstreet <kent.overstreet@linux.dev> 2023-04-21 03:33:45 -0400
committerGravatar Kent Overstreet <kent.overstreet@linux.dev> 2023-10-22 17:10:00 -0400
commit09ebfa61130edaa990c0f1865fe2fa536d67c313 (patch)
treee12495ab951557bab0dfc85b7f6ea883fcde3080 /fs
parentbcachefs: remove bucket_gens btree keys on device removal (diff)
downloadlinux-09ebfa61130edaa990c0f1865fe2fa536d67c313.tar.gz
linux-09ebfa61130edaa990c0f1865fe2fa536d67c313.tar.bz2
linux-09ebfa61130edaa990c0f1865fe2fa536d67c313.zip
bcachefs: Drop a redundant error message
When we're already read-only, we don't need to print out errors from writing btree nodes. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs')
-rw-r--r--fs/bcachefs/btree_io.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/bcachefs/btree_io.c b/fs/bcachefs/btree_io.c
index 0489d07a087f..decbbaace1ee 100644
--- a/fs/bcachefs/btree_io.c
+++ b/fs/bcachefs/btree_io.c
@@ -1746,7 +1746,7 @@ static void btree_node_write_work(struct work_struct *work)
struct bch_fs *c = wbio->wbio.c;
struct btree *b = wbio->wbio.bio.bi_private;
struct bch_extent_ptr *ptr;
- int ret;
+ int ret = 0;
btree_bounce_free(c,
wbio->data_bytes,
@@ -1776,7 +1776,8 @@ out:
return;
err:
set_btree_node_noevict(b);
- bch2_fs_fatal_error(c, "fatal error writing btree node");
+ if (!bch2_err_matches(ret, EROFS))
+ bch2_fs_fatal_error(c, "fatal error writing btree node");
goto out;
}