diff options
author | 2018-01-03 11:16:26 -0800 | |
---|---|---|
committer | 2018-01-12 23:03:35 +1100 | |
commit | a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e (patch) | |
tree | e700ec232c2831a0471ce788552c69db8cc6c949 /include/acpi | |
parent | crypto: poly1305 - remove ->setkey() method (diff) | |
download | linux-a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e.tar.gz linux-a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e.tar.bz2 linux-a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e.zip |
crypto: hash - annotate algorithms taking optional key
We need to consistently enforce that keyed hashes cannot be used without
setting the key. To do this we need a reliable way to determine whether
a given hash algorithm is keyed or not. AF_ALG currently does this by
checking for the presence of a ->setkey() method. However, this is
actually slightly broken because the CRC-32 algorithms implement
->setkey() but can also be used without a key. (The CRC-32 "key" is not
actually a cryptographic key but rather represents the initial state.
If not overridden, then a default initial state is used.)
Prepare to fix this by introducing a flag CRYPTO_ALG_OPTIONAL_KEY which
indicates that the algorithm has a ->setkey() method, but it is not
required to be called. Then set it on all the CRC-32 algorithms.
The same also applies to the Adler-32 implementation in Lustre.
Also, the cryptd and mcryptd templates have to pass through the flag
from their underlying algorithm.
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'include/acpi')
0 files changed, 0 insertions, 0 deletions