diff options
| author |  Eric Biggers <ebiggers@google.com>
| 2019-01-03 20:16:13 -0800 |
|---|---|---|
| committer |  Herbert Xu <herbert@gondor.apana.org.au>
| 2019-01-11 14:16:57 +0800 |
| commit | 251b7aea34ba3c4d4fdfa9447695642eb8b8b098 (patch) | |
| tree | 4e2b2ce50c7f79ac784abfc4332f2301d51cf4e9 /include/crypto/internal/skcipher.h | |
| parent | crypto: ofb - fix handling partial blocks and make thread-safe (diff) | |
| download | linux-251b7aea34ba3c4d4fdfa9447695642eb8b8b098.tar.gz linux-251b7aea34ba3c4d4fdfa9447695642eb8b8b098.tar.bz2 linux-251b7aea34ba3c4d4fdfa9447695642eb8b8b098.zip | |
crypto: pcbc - remove bogus memcpy()s with src == dest
The memcpy()s in the PCBC implementation use walk->iv as both the source
and destination, which has undefined behavior. These memcpy()'s are
actually unneeded, because walk->iv is already used to hold the previous
plaintext block XOR'd with the previous ciphertext block. Thus,
walk->iv is already updated to its final value.
So remove the broken and unnecessary memcpy()s.
Fixes: 91652be5d1b9 ("[CRYPTO] pcbc: Add Propagated CBC template")
Cc: <stable@vger.kernel.org> # v2.6.21+
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'include/crypto/internal/skcipher.h')
0 files changed, 0 insertions, 0 deletions