diff options
author | 2012-09-14 18:52:10 +0200 | |
---|---|---|
committer | 2012-09-29 21:21:53 +0200 | |
commit | 1b08e907211cdc744f54871736005d9f3e7f182c (patch) | |
tree | df62046438501ecd89e0bac1fb9b73edaf622e15 /include/linux/uprobes.h | |
parent | uprobes: Fix UPROBE_SKIP_SSTEP checks in handle_swbp() (diff) | |
download | linux-1b08e907211cdc744f54871736005d9f3e7f182c.tar.gz linux-1b08e907211cdc744f54871736005d9f3e7f182c.tar.bz2 linux-1b08e907211cdc744f54871736005d9f3e7f182c.zip |
uprobes: Kill UTASK_BP_HIT state
Kill UTASK_BP_HIT state, it buys nothing but complicates the code.
It is only used in uprobe_notify_resume() to decide who should be
called, we can check utask->active_uprobe != NULL instead. And this
allows us to simplify handle_swbp(), no need to clear utask->state.
Likewise we could kill UTASK_SSTEP, but UTASK_BP_HIT is worse and
imho should die. The problem is, it creates the special case when
task->utask is NULL, we can't distinguish RUNNING and BP_HIT. With
this patch utask == NULL always means RUNNING.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'include/linux/uprobes.h')
-rw-r--r-- | include/linux/uprobes.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index e6f0331e3d45..18d839da6517 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h @@ -59,7 +59,6 @@ struct uprobe_consumer { #ifdef CONFIG_UPROBES enum uprobe_task_state { UTASK_RUNNING, - UTASK_BP_HIT, UTASK_SSTEP, UTASK_SSTEP_ACK, UTASK_SSTEP_TRAPPED, |