diff options
| author |  Hugh Dickins <hughd@google.com>
| 2022-03-24 18:13:59 -0700 |
|---|---|---|
| committer |  Linus Torvalds <torvalds@linux-foundation.org>
| 2022-03-24 19:06:51 -0700 |
| commit | 566d3362885aab04d6b0f885f12db3176ca3a032 (patch) | |
| tree | 25ac4e4fd25635a26587151d6b54a90a9e86888d /include/linux | |
| parent | mm/huge_memory: remove stale locking logic from __split_huge_pmd() (diff) | |
| download | linux-566d3362885aab04d6b0f885f12db3176ca3a032.tar.gz linux-566d3362885aab04d6b0f885f12db3176ca3a032.tar.bz2 linux-566d3362885aab04d6b0f885f12db3176ca3a032.zip | |
mm: warn on deleting redirtied only if accounted
filemap_unaccount_folio() has a WARN_ON_ONCE(folio_test_dirty(folio)). It
is good to warn of late dirtying on a persistent filesystem, but late
dirtying on tmpfs can only lose data which is expected to be thrown away;
and it's a pity if that warning comes ONCE on tmpfs, then hides others
which really matter. Make it conditional on mapping_cap_writeback().
Cleanup: then folio_account_cleaned() no longer needs to check that for
itself, and so no longer needs to know the mapping.
Link: https://lkml.kernel.org/r/b5a1106c-7226-a5c6-ad41-ad4832cae1f@google.com
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Jan Kara <jack@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/pagemap.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 58f395f3febe..a8d0b327b066 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -1009,8 +1009,7 @@ static inline void __set_page_dirty(struct page *page, { __folio_mark_dirty(page_folio(page), mapping, warn); } -void folio_account_cleaned(struct folio *folio, struct address_space *mapping, - struct bdi_writeback *wb); +void folio_account_cleaned(struct folio *folio, struct bdi_writeback *wb); void __folio_cancel_dirty(struct folio *folio); static inline void folio_cancel_dirty(struct folio *folio) { |