diff options
| author |  Hao Xu <howeyxu@tencent.com>
| 2022-06-16 10:22:02 +0100 |
|---|---|---|
| committer |  Jens Axboe <axboe@kernel.dk>
| 2022-07-24 18:39:13 -0600 |
| commit | 38513c464d3d45b4088c82f6e42d9cdbc5ee57e6 (patch) | |
| tree | defce3565cffbddce9dda6a8466298939015584c /io_uring/cancel.c | |
| parent | io_uring: poll: remove unnecessary req->ref set (diff) | |
| download | linux-38513c464d3d45b4088c82f6e42d9cdbc5ee57e6.tar.gz linux-38513c464d3d45b4088c82f6e42d9cdbc5ee57e6.tar.bz2 linux-38513c464d3d45b4088c82f6e42d9cdbc5ee57e6.zip | |
io_uring: switch cancel_hash to use per entry spinlock
Add a new io_hash_bucket structure so that each bucket in cancel_hash
has separate spinlock. Use per entry lock for cancel_hash, this removes
some completion lock invocation and remove contension between different
cancel_hash entries.
Signed-off-by: Hao Xu <howeyxu@tencent.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/05d1e135b0c8bce9d1441e6346776589e5783e26.1655371007.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring/cancel.c')
| -rw-r--r-- | io_uring/cancel.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/io_uring/cancel.c b/io_uring/cancel.c index 83cceb52d82d..6f2888388a40 100644 --- a/io_uring/cancel.c +++ b/io_uring/cancel.c @@ -93,14 +93,14 @@ int io_try_cancel(struct io_kiocb *req, struct io_cancel_data *cd) if (!ret) return 0; - spin_lock(&ctx->completion_lock); ret = io_poll_cancel(ctx, cd); if (ret != -ENOENT) goto out; + spin_lock(&ctx->completion_lock); if (!(cd->flags & IORING_ASYNC_CANCEL_FD)) ret = io_timeout_cancel(ctx, cd); -out: spin_unlock(&ctx->completion_lock); +out: return ret; } @@ -192,3 +192,13 @@ done: io_req_set_res(req, ret, 0); return IOU_OK; } + +void init_hash_table(struct io_hash_bucket *hash_table, unsigned size) +{ + unsigned int i; + + for (i = 0; i < size; i++) { + spin_lock_init(&hash_table[i].lock); + INIT_HLIST_HEAD(&hash_table[i].list); + } +} |