diff options
| author |  Cupertino Miranda <cupertino.miranda@oracle.com>
| 2024-05-06 15:18:46 +0100 |
|---|---|---|
| committer |  Alexei Starovoitov <ast@kernel.org>
| 2024-05-06 17:09:11 -0700 |
| commit | 138cc42c05d11fd5ee82ee1606d2c9823373a926 (patch) | |
| tree | 383933f497a27b1046f720057b979d727e0d0516 /kernel/bpf | |
| parent | bpf/verifier: refactor checks for range computation (diff) | |
| download | linux-138cc42c05d11fd5ee82ee1606d2c9823373a926.tar.gz linux-138cc42c05d11fd5ee82ee1606d2c9823373a926.tar.bz2 linux-138cc42c05d11fd5ee82ee1606d2c9823373a926.zip | |
bpf/verifier: improve XOR and OR range computation
Range for XOR and OR operators would not be attempted unless src_reg
would resolve to a single value, i.e. a known constant value.
This condition is unnecessary, and the following XOR/OR operator
handling could compute a possible better range.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Cc: Yonghong Song <yonghong.song@linux.dev>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: David Faust <david.faust@oracle.com>
Cc: Jose Marchesi <jose.marchesi@oracle.com>
Cc: Elena Zannoni <elena.zannoni@oracle.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Link: https://lore.kernel.org/r/20240506141849.185293-4-cupertino.miranda@oracle.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel/bpf')
| -rw-r--r-- | kernel/bpf/verifier.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index bdaf0413bf06..1f6deb3e44c5 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -13900,12 +13900,12 @@ static bool is_safe_to_compute_dst_reg_range(struct bpf_insn *insn, case BPF_ADD: case BPF_SUB: case BPF_AND: + case BPF_XOR: + case BPF_OR: return true; /* Compute range for the following only if the src_reg is const. */ - case BPF_XOR: - case BPF_OR: case BPF_MUL: return src_is_const; |