diff options
| author |  linke li <lilinke99@qq.com>
| 2024-03-06 19:51:10 -0800 |
|---|---|---|
| committer |  Uladzislau Rezki (Sony) <urezki@gmail.com>
| 2024-04-16 11:16:35 +0200 |
| commit | a10e3cbf32786cae437e4f370573318721e47c2c (patch) | |
| tree | d98a912ce5cbf70085ef6057c23c5308fdb0fba5 /kernel/rcu | |
| parent | rcutorture: Fix rcu_torture_one_read() pipe_count overflow comment (diff) | |
| download | linux-a10e3cbf32786cae437e4f370573318721e47c2c.tar.gz linux-a10e3cbf32786cae437e4f370573318721e47c2c.tar.bz2 linux-a10e3cbf32786cae437e4f370573318721e47c2c.zip | |
rcutorture: Re-use value stored to ->rtort_pipe_count instead of re-reading
Currently, the rcu_torture_pipe_update_one() writes the value (i + 1)
to rp->rtort_pipe_count, then immediately re-reads it in order to compare
it to RCU_TORTURE_PIPE_LEN. This re-read is pointless because no other
update to rp->rtort_pipe_count can occur at this point. This commit
therefore instead re-uses the (i + 1) value stored in the comparison
instead of re-reading rp->rtort_pipe_count.
Signed-off-by: linke li <lilinke99@qq.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Diffstat (limited to 'kernel/rcu')
| -rw-r--r-- | kernel/rcu/rcutorture.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 0cb5452ecd94..dd7d5ba45740 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -467,7 +467,7 @@ rcu_torture_pipe_update_one(struct rcu_torture *rp) atomic_inc(&rcu_torture_wcount[i]); WRITE_ONCE(rp->rtort_pipe_count, i + 1); ASSERT_EXCLUSIVE_WRITER(rp->rtort_pipe_count); - if (rp->rtort_pipe_count >= RCU_TORTURE_PIPE_LEN) { + if (i + 1 >= RCU_TORTURE_PIPE_LEN) { rp->rtort_mbtest = 0; return true; } |