diff options
| author |  Thomas Gleixner <tglx@linutronix.de>
| 2020-10-20 16:46:55 +0200 |
|---|---|---|
| committer |  Peter Zijlstra <peterz@infradead.org>
| 2020-10-29 11:00:31 +0100 |
| commit | 345a957fcc95630bf5535d7668a59ed983eb49a7 (patch) | |
| tree | bbbd19bc6999cfbdcb939d1e59f1b3d04cf1848a /kernel/sched | |
| parent | sched: membarrier: document memory ordering scenarios (diff) | |
| download | linux-345a957fcc95630bf5535d7668a59ed983eb49a7.tar.gz linux-345a957fcc95630bf5535d7668a59ed983eb49a7.tar.bz2 linux-345a957fcc95630bf5535d7668a59ed983eb49a7.zip | |
sched: Reenable interrupts in do_sched_yield()
do_sched_yield() invokes schedule() with interrupts disabled which is
not allowed. This goes back to the pre git era to commit a6efb709806c
("[PATCH] irqlock patch 2.5.27-H6") in the history tree.
Reenable interrupts and remove the misleading comment which "explains" it.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/87r1pt7y5c.fsf@nanos.tec.linutronix.de
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/core.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index d2003a7d5ab5..6f533bb7d3b9 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6094,12 +6094,8 @@ static void do_sched_yield(void) schedstat_inc(rq->yld_count); current->sched_class->yield_task(rq); - /* - * Since we are going to call schedule() anyway, there's - * no need to preempt or enable interrupts: - */ preempt_disable(); - rq_unlock(rq, &rf); + rq_unlock_irq(rq, &rf); sched_preempt_enable_no_resched(); schedule(); |