diff options
| author |  Oleg Nesterov <oleg@tv-sign.ru>
| 2006-01-10 17:24:53 +0300 |
|---|---|---|
| committer |  Linus Torvalds <torvalds@g5.osdl.org>
| 2006-01-10 08:49:47 -0800 |
| commit | a9c828155ae8d1a1576f9648cc4d9677aea53f89 (patch) | |
| tree | 7b087188579ff897332a767af1ff695ab5bc116f /kernel | |
| parent | [PATCH] rcu: join rcu_ctrlblk and rcu_state (diff) | |
| download | linux-a9c828155ae8d1a1576f9648cc4d9677aea53f89.tar.gz linux-a9c828155ae8d1a1576f9648cc4d9677aea53f89.tar.bz2 linux-a9c828155ae8d1a1576f9648cc4d9677aea53f89.zip | |
[PATCH] rcu: fix hotplug-cpu ->donelist leak
Pointed out by Srivatsa Vaddagiri <vatsa@in.ibm.com>.
rcu_do_batch() stops after processing maxbatch callbacks
on ->donelist leaving rcu_tasklet in TASKLET_STATE_SCHED
state.
If CPU_DEAD event happens remaining ->donelist entries are
lost, rcu_offline_cpu() kills this tasklet.
With this patch ->donelist migrates along with ->curlist
and ->nxtlist to the current cpu.
Compile tested.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
Cc: Srivatsa Vaddagiri <vatsa@in.ibm.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/rcupdate.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c index e18f9190eafa..0cf8146bd585 100644 --- a/kernel/rcupdate.c +++ b/kernel/rcupdate.c @@ -343,8 +343,9 @@ static void __rcu_offline_cpu(struct rcu_data *this_rdp, spin_unlock_bh(&rcp->lock); rcu_move_batch(this_rdp, rdp->curlist, rdp->curtail); rcu_move_batch(this_rdp, rdp->nxtlist, rdp->nxttail); - + rcu_move_batch(this_rdp, rdp->donelist, rdp->donetail); } + static void rcu_offline_cpu(int cpu) { struct rcu_data *this_rdp = &get_cpu_var(rcu_data); |