aboutsummaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorGravatar Mark Brown <broonie@kernel.org> 2024-04-30 23:36:23 +0900
committerGravatar Mark Brown <broonie@kernel.org> 2024-04-30 23:36:23 +0900
commitc5782bb5468acf86d8ca8e161267e8d055fb4161 (patch)
tree404c44427f17934b130e1aff10bdb8bb34ee5b2d /kernel
parentASoC: cs35l56: fix usages of device_get_named_child_node() (diff)
parentASoC: meson: axg-tdm: add continuous clock support (diff)
downloadlinux-c5782bb5468acf86d8ca8e161267e8d055fb4161.tar.gz
linux-c5782bb5468acf86d8ca8e161267e8d055fb4161.tar.bz2
linux-c5782bb5468acf86d8ca8e161267e8d055fb4161.zip
ASoC: meson: tdm fixes
Merge series from Jerome Brunet <jbrunet@baylibre.com>: This patchset fixes 2 problems on TDM which both find a solution by properly implementing the .trigger() callback for the TDM backend. ATM, enabling the TDM formatters is done by the .prepare() callback because handling the formatter is slow due to necessary calls to CCF. The first problem affects the TDMIN. Because .prepare() is called on DPCM backend first, the formatter are started before the FIFOs and this may cause a random channel shifts if the TDMIN use multiple lanes with more than 2 slots per lanes. Using trigger() allows to set the FE/BE order, solving the problem. There has already been an attempt to fix this 3y ago [1] and reverted [2] It triggered a 'sleep in irq' error on the period IRQ. The solution is to just use the bottom half of threaded IRQ. This is patch #1. Patch #2 and #3 remain mostly the same as 3y ago. For TDMOUT, the problem is on pause. ATM pause only stops the FIFO and the TDMOUT just starves. When it does, it will actually repeat the last sample continuously. Depending on the platform, if there is no high-pass filter on the analog path, this may translate to a constant position of the speaker membrane. There is no audible glitch but it may damage the speaker coil. Properly stopping the TDMOUT in pause solves the problem. There is behaviour change associated with that fix. Clocks used to be continuous on pause because of the problem above. They will now be gated on pause by default, as they should. The last change introduce the proper support for continuous clocks, if needed. [1]: https://lore.kernel.org/linux-amlogic/20211020114217.133153-1-jbrunet@baylibre.com [2]: https://lore.kernel.org/linux-amlogic/20220421155725.2589089-1-narmstrong@baylibre.com
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions